Fix request processor endless loop #90
Conversation
JackyWoo
force-pushed
the
request_processor_endless_loop
branch
from
eee45f5 to
8e6114d
Compare
JackyWoo
force-pushed
the
request_processor_endless_loop
branch
2 times, most recently
from
d5b7677 to
8ebc875
Compare
JackyWoo
force-pushed
the
request_processor_endless_loop
branch
from
8ebc875 to
7f403e1
Compare
|
The CI error is data race and will be fixed here #90 |
src/Service/RequestProcessor.cpp
Outdated
| processCommittedRequest(committed_request_size); | ||
|
|
||
| /// 3. process error requests | ||
| processErrorRequest(); |
There was a problem hiding this comment.
Need to get the number of current errors in advance, before moving to the pending queue, so as to ensure that the processed errors have been added to the pending queue.
There was a problem hiding this comment.
Now errors is a map, we can't handle n items in order, we can use list instead of map to hold errors.
| if (found_error) | ||
| LOG_WARNING(log, "Found error request, We should terminate the processing of committed(write) requests."); | ||
| else | ||
| process_not_in_pending_queue(); |
There was a problem hiding this comment.
May previous request is error but not in errors queue yet, may we need traverse pending queue to judgement commit request whether in pending queue.
There was a problem hiding this comment.
Here first_pending_request.request->xid != committed_request.request->xid, maybe there is no need to traverse pending queue.
* Fix request processor endless loop * Fix typo * Use list for errors
* Fix request processor endless loop * Fix typo * Use list for errors
Which issues of this PR fixes:
This PR try to fix #89
Change log:
KeeperCommon.hwhich contains common prototypes such asRequestForSessionKeeperCommon.htoKeeperUtils.hRequestIdinstead of UInt28(session_id, xid)sessionCleanerTaskwill notfinishSession