Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race error in request processor #96

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix data race error in request processor #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Service/RequestProcessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ void RequestProcessor::run()
return;

size_t committed_request_size = committed_queue.size();
size_t error_request_size = error_request_ids.size();
size_t error_request_size;
{
std::unique_lock lk(mutex);
error_request_size = error_request_ids.size();
}

/// 1. process read request, multi thread
for (RunnerId runner_id = 0; runner_id < runner_count; runner_id++)
Expand Down