You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's this confusing _do_test function that I've duplicated throughout the tests. It ends up making a lot of the unit tests look like magic and doesn't necessarily help someone if they are using the unit tests to understand normal usage of the library.
Further, _do_test should be generalized, rewritten with better variable names, comments etc. if the code cannot be made more legible, so that maintainers don't have to copy it to each test suite.
_do_test ITSELF should be unit tested if tests depend on it!
The text was updated successfully, but these errors were encountered:
There's this confusing _do_test function that I've duplicated throughout the tests. It ends up making a lot of the unit tests look like magic and doesn't necessarily help someone if they are using the unit tests to understand normal usage of the library.
Nothing is accessed, asserted, etc.
I feel like the tests themselves should be updated to at least show that the CBOR payload members are accessible as part of the type:
Further, _do_test should be generalized, rewritten with better variable names, comments etc. if the code cannot be made more legible, so that maintainers don't have to copy it to each test suite.
_do_test ITSELF should be unit tested if tests depend on it!
The text was updated successfully, but these errors were encountered: