Do we want active rules to be listed as bools #538
JakeRoggenbuck
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Two ideas:
Currently, we store rules like this and access them like this...
We check
.contains
more than we need to because the config is only read once at the start and should not be changed. We could do one of two things. (A) change the config to be bools to reduce calls. This would mean each rule has aac_charging_rule = true
instead of including "ac_charging_rule" to the active rules list.Alternatively (B), we could read the rules from the list and have hidden config bools that are set when the list is set.
What do y'all think? @Shuzhengz @Camerooooon
Beta Was this translation helpful? Give feedback.
All reactions