Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Governor Mode Switch Notifications #551

Open
JakeRoggenbuck opened this issue Dec 5, 2023 · 3 comments · May be fixed by #556
Open

Optional Governor Mode Switch Notifications #551

JakeRoggenbuck opened this issue Dec 5, 2023 · 3 comments · May be fixed by #556
Assignees
Labels
feature request Request a new feature good first issue Good for newcomers

Comments

@JakeRoggenbuck
Copy link
Owner

When the governor mode changes, send a notify-send

@JakeRoggenbuck JakeRoggenbuck added feature request Request a new feature good first issue Good for newcomers labels Dec 12, 2023
@Camerooooon Camerooooon self-assigned this Feb 13, 2024
@Camerooooon
Copy link
Collaborator

I'm curious what the use case would be here, would anyone realistically want to be notified every single time the governor is changed?

@Camerooooon
Copy link
Collaborator

An implementation hurdle I just reached was the fact that you cannot send a notification as root. This means auto clock speed would need to have a second, user level daemon or fork a new user level process to send notifications. hoodie/notify-rust#156

The solution I've found is to spawn a user process that is in charge of sending the notification https://stackoverflow.com/questions/28195805/running-notify-send-as-root

Seems like a lot of overhead just to send a notification, happy to implement some code which forks the process in the user space if we want to go through with this feature.

@JakeRoggenbuck @Shuzhengz thoughts?

@Camerooooon Camerooooon linked a pull request Feb 13, 2024 that will close this issue
@Camerooooon Camerooooon linked a pull request Feb 13, 2024 that will close this issue
@JakeRoggenbuck
Copy link
Owner Author

Good solution! It's totally up to you if you wanna write the process part. Saw your PR and it looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a new feature good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants