Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread panic sometimes when attempting to fetch CPU info on Thinkpad X1 Nano Gen 1 #557

Open
Camerooooon opened this issue Feb 22, 2024 · 3 comments · May be fixed by #558
Open

Thread panic sometimes when attempting to fetch CPU info on Thinkpad X1 Nano Gen 1 #557

Camerooooon opened this issue Feb 22, 2024 · 3 comments · May be fixed by #558
Labels
bug Something isn't working

Comments

@Camerooooon
Copy link
Collaborator

Describe the bug
I'm getting a thread panic on my new Thinkpad X1 Nano Gen 1 sometimes when attempting to fetch CPU information. I think the problem is a kernel bug which prevents the data from being read however it should be handled properly instead of panicking.

To Reproduce
Steps to reproduce the behavior:

  1. Run command 'acs get cpus'
  2. Received error

Expected behavior
The os error 61 should be handled properly instead of panicking.

**Screenshots
20240222_12h09m04s_grim

Version
autoclockspeed 0.1.11 installed with cargo install

I will work to fix this issue since it seems to be a hardware issue with my specific laptop and might be difficult to reproduce.
@Camerooooon Camerooooon added the bug Something isn't working label Feb 22, 2024
@Camerooooon
Copy link
Collaborator Author

20240222_12h17m44s_grim

Seems like the issue is with a certain thermal zone not reading properly on my system, I bet it is a known issue with my outdated firmware/bios which I haven't updated in a while. I'll try to fix the panic within auto-clock-speed either way then update my computer.

@Camerooooon
Copy link
Collaborator Author

Update: the thermal zone is now working and auto clock speed is functioning as expected now. We for sure need to improve error handling on this front because acs should not stop working just because one thermal zone cannot be read. I will work on this issue.

@JakeRoggenbuck
Copy link
Owner

Thanks!!

@Camerooooon Camerooooon linked a pull request Feb 23, 2024 that will close this issue
Fix panic when IO error for some cpu features #558
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panic when IO error for some cpu features Camerooooon/clockspeed
2 participants
@JakeRoggenbuck @Camerooooon