Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner unittests #66

Open
AleksanderRDL opened this issue Jun 9, 2023 · 1 comment · May be fixed by #107
Open

Cleaner unittests #66

AleksanderRDL opened this issue Jun 9, 2023 · 1 comment · May be fixed by #107
Labels
enhancement New feature or request MediumPrio Its not really a "high" priority, however its not negligible either

Comments

@AleksanderRDL
Copy link
Collaborator

AleksanderRDL commented Jun 9, 2023 •
edited
Loading

Reformat unittests to better seperate what the test evaluates. The content of the unittests should also be made sure it covers all possible usecases of the tested logic. (eg. if it is a plusAssign test, the test should try and plusAssign with all possible types and cases which plusAssign can appear in)
@AleksanderRDL AleksanderRDL added the enhancement New feature or request label Jun 9, 2023
@AleksanderRDL AleksanderRDL added the MediumPrio Its not really a "high" priority, however its not negligible either label Jun 9, 2023
@Aavild Aavild mentioned this issue Jun 20, 2023
Closed
@Aavild
Copy link
Collaborator

Aavild commented Jun 26, 2023

Also add so that either a typecheck evaluates true or check that exception is created correctly. (so no longer true/false but rather true/exceptiontrace)

@Aavild Aavild linked a pull request Jun 29, 2023 that will close this issue
66 cleaner unittests, filedirectory and looser coupling #107
Open
@Aavild Aavild linked a pull request Jun 29, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request MediumPrio Its not really a "high" priority, however its not negligible either
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

66 cleaner unittests, filedirectory and looser coupling JakobTopholt/P4-Unitino
2 participants
@Aavild @AleksanderRDL