Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-cedarling): Add bootstrap properties of memory logger max_items and max_item_size #10614

Open
olehbozhok opened this issue Jan 13, 2025 · 0 comments
Assignees
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-feature Issue or PR is a new feature request
Milestone

Comments

@olehbozhok
Copy link
Contributor

olehbozhok commented Jan 13, 2025

Is your feature request related to a problem? Please describe.
Memory logger use sparkv memory database. Next parameters are hard-coded:

    max_items: usize,
    max_item_size: usize,

Describe the solution you'd like
Add bootstrap properties to memory logger and avoid use hard-coded configuration data for these parameters.

If log entry bigger than max_item_size we just skip it and write message to stderr (or browser console if WASM)

If value is zero or -1 it means we skip this check

@olehbozhok olehbozhok added comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-feature Issue or PR is a new feature request labels Jan 13, 2025
@olehbozhok olehbozhok self-assigned this Jan 13, 2025
@moabu moabu added this to the next-release milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-feature Issue or PR is a new feature request
Projects
None yet
Development

No branches or pull requests

2 participants