Skip to content

Commit

Permalink
Merge pull request #4 from Janus-vistaprint/fix_destroy_timing
Browse files Browse the repository at this point in the history
removing create before destroy to fix rebuild timing
  • Loading branch information
jcharette authored May 8, 2017
2 parents 0b88171 + c49797b commit 6e347d8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
2 changes: 2 additions & 0 deletions tf_ecs_default_service/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ resource "aws_ecs_service" "svc" {
field = "instanceId"
}

/* enabling this breaks teardown/rebuild
lifecycle {
create_before_destroy = true
}
*/
}

data "template_file" "task_definition" {
Expand Down
8 changes: 5 additions & 3 deletions tf_ecs_service/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ resource "aws_ecs_service" "svc" {
field = "instanceId"
}

lifecycle {
create_before_destroy = true
}
# We have found that create_before_destroy breaks teardown.
#lifecycle {
# create_before_destroy = true
#}

}

data "template_file" "task_definition" {
Expand Down

0 comments on commit 6e347d8

Please sign in to comment.