Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of settings file entrypoint assumption in core #67

Open
4 tasks
JasonYao opened this issue Feb 15, 2019 · 0 comments
Open
4 tasks

Get rid of settings file entrypoint assumption in core #67

JasonYao opened this issue Feb 15, 2019 · 0 comments
Labels
Easiness 3 Harder/larger feature/refactor/bugfix Priority 1 Second highest priority

Comments

@JasonYao
Copy link
Owner

JasonYao commented Feb 15, 2019

Background

  • feat(developer environments): Adds in the ability to install language runtimes and venvs #65 introduced developer environments, the use of a common schema shared between other schemas, and most importantly a change in the validator to validate all .json/.yaml/.yml files by default.
  • This means two things:
    • We are no longer tied to settings.yaml/json/yml as the entrypoint for a module. This should be reflected in docs and examples
    • We are able to run multiple files in a given directory
      • This means either that we need multiple Module objects, or for each file create a Module object

Tasks

  • Validator: Get rid of default_settings_file in alpha.core schema
  • Core: Get rid of the logic isolating for settings.yaml/json/yml, and replace with a tree walk (Normalize file loading #71)
  • Validator -> Core: Migrate the logic where the files are chosen from the validator to pydotfiles.common or someplace else, and then have both core and the validator call this (Normalize file loading #71)
  • Add in a test that has a random json file in there somewhere- we should not end up validating the json file in that case (Add in support for file ignoring #72)
    • One approach here would be to add in support for ignoring certain files. Maybe adding in support for a .pydotfilesignore file?
@JasonYao JasonYao added Priority 1 Second highest priority Easiness 3 Harder/larger feature/refactor/bugfix labels Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easiness 3 Harder/larger feature/refactor/bugfix Priority 1 Second highest priority
Projects
None yet
Development

No branches or pull requests

1 participant