Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in per-os version build files #81

Open
JasonYao opened this issue Oct 16, 2022 · 2 comments
Open

Add in per-os version build files #81

JasonYao opened this issue Oct 16, 2022 · 2 comments

Comments

@JasonYao
Copy link
Owner

right now, we do a check in our default settings for macos that looks like this:

def template_os_default_setting(data: DefaultSettings) -> str:
    if not data.should_run(get_current_mac_version()):
        # blah blah blah
        pass
    pass

This comes with two major drawback:

  1. Linux build runners are unable to actually build macos build packages since there's no current_mac_version
  2. Presuming that we have multiple macos versions, it'd be nice to have per os version configs.
  • Currently, my personal mac is on Big Sur, while my work mac is on whatever the latest version is. This could be solved by adding in a field for os version in the profile manifest.

Before

version: "alpha"
schema: "manifest"
profiles:
  work:
    - core
    - work
  personal:
    - core
    - dev
    - personal

After

version: "alpha"
schema: "manifest"
profiles:
  work:
    dependencies:
      - core
      - work
    os_versions:
      macos:
        - 11.7
        - latest
      linux
        - <insert glinux version here>
  personal:
    dependencies:
      - core
      - dev
      - personal
    os_versions:
      macos:
        - 11.5
        - latest
      linux
        - <insert whatever raspberry-pi or other personal project linux version here>
@JasonYao
Copy link
Owner Author

@JasonYao
Copy link
Owner Author

lazy approach for now: just supplying a default MacVersion value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant