Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When performing a screeneffect on a player, it starts rain #4

Open
TheNylox opened this issue Sep 24, 2024 · 3 comments
Open

When performing a screeneffect on a player, it starts rain #4

TheNylox opened this issue Sep 24, 2024 · 3 comments

Comments

@TheNylox
Copy link

If i perform a screeneffect on a player, or myself, it start rain. It's a fake client side rain because the server its not really raining. If you relog the rain disappear.

ItemAdder 4.0.2
LoneLibs 1.0.59
ScreenEffect 1.0.17
Paper 1.21.1 b96

@TheNylox
Copy link
Author

I made a fix that seem working if you want to have a look:
https://github.com/TheNylox/ScreenEffects/tree/main

@SniperTVmc
Copy link

Thanks dude, I didn't understand why it was raining on every execution, specially because I didn't have this problem in 1.20 (I think it's the packets that must have changed), so thanks for the fix I'm going to use it until the developer fixes it. ( otherwise you can always contribute via a pull request, it'll “save time”)

@TheNylox
Copy link
Author

TheNylox commented Nov 10, 2024

Thanks dude, I didn't understand why it was raining on every execution, specially because I didn't have this problem in 1.20 (I think it's the packets that must have changed), so thanks for the fix I'm going to use it until the developer fixes it. ( otherwise you can always contribute via a pull request, it'll “save time”)

I didn't ask for a pull because i removed all retro-compatibility. My fix works only for 1.21. Also it still have some problems, its just a temporary one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants