Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Mekanism Integration respect Chemical Attributes that require special handling #14

Open
pupnewfster opened this issue Mar 23, 2021 · 0 comments

Comments

@pupnewfster
Copy link

pupnewfster commented Mar 23, 2021

The isAllowed method should really be validating if the chemical stack requires any special handling or not:

if (!ChemicalAttributeValidator.process(result, ChemicalAttributeValidator.DEFAULT))
    return false;

If you really want you could probably include a config option (defaulted to respecting the chemical attributes), but as it stands this mod currently is allowing for trivializing voiding nuclear waste (and any other chemicals that specifically mark that they require extra validation for if containers/systems can handle them) without having to deal with it.

If this is respected somewhere else and I overlooked it in my very brief glance feel free to just close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant