Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure analysis is idempotent #2

Open
Javex opened this issue Oct 3, 2023 · 0 comments
Open

Make sure analysis is idempotent #2

Javex opened this issue Oct 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Javex
Copy link
Owner

Javex commented Oct 3, 2023

When re-running analysis the code should not break things like price history if the same scraped snapshot is used (i.e. we didn't re-scrape, just re-analyse). However, at the moment I've noticed in some cases this breaks in odd ways, not sure why. For example, even though the items are all there, the prices changes page somehow filtered out all items, possibly because of the price history got cleared. I haven't reproduced it yet so I'm not sure what exactly is happening there.
@Javex Javex added the bug Something isn't working label Oct 3, 2023
Javex added a commit that referenced this issue Oct 3, 2023
@Javex
Add more merge test cases
b68d059 
These were supposed to fail, but unfortunately didn't, so the bug is not
as simple as the test cases try to check. However, I'll still leave them
in since they're worth having. The bug described in #2 is probably
elsewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Javex