Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burp / stability cuts adversely affect Beam Mod #245

Open
cameronc137 opened this issue Aug 21, 2019 · 1 comment
Open

Burp / stability cuts adversely affect Beam Mod #245

cameronc137 opened this issue Aug 21, 2019 · 1 comment

Comments

@cameronc137
Copy link
Collaborator

Environment: (where does this bug occur, have you tried other environments)

The cut in question (as of this current build) is one of kErrorFlag_BurpCut = 0x20000000 or kBeamStabilityError= 0x10000000

Problem

Beam mod trips the error flag due to its large (intentional) fluctutations

Proposed solutions

  • Use these flags in analysis to avoid these trips
  • Update JAPAN to have these flags overwritten by the BMOD flag
  • Turn these cuts back off
@paulmking
Copy link
Collaborator

I think the best solution is to have the BMOD analysis ignore the burp cut, and perhaps the stability cut if needed. Let's investigate further. There is active discussion in the BMW slack channel as I type this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants