Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should skip the data points out of analysis space for unbinned loglikelihood #44

Open
yuema137 opened this issue Jun 11, 2024 · 0 comments

Comments

@yuema137
Copy link

In BinnedLogLikelihood we set the data with the bins defined by analysis space:

dimnames, bins = zip(*self.base_model.config['analysis_space'])
self.data_events_per_bin = Histdd(bins=bins, axis_names=dimnames)
self.data_events_per_bin.add(*self.base_model.to_analysis_dimensions(d))

Therefore, the data is automatically chopped. However in UnbinnedLogLikelihood there is no such an operation. As the pdfs are interpolated & extrapolated, the program doesn't know which data points are out of bound, and therefore perform a lot of redundant calculations for the cost function which slow down the call a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant