-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update on humble branch #68
Comments
Hi, did you check https://github.com/kongoncharuk/gazebo-pkgs/tree/humble? Otherwise I expect to get it done myself within the next month. I can let you know once it's done as soon as I'm done, if you didn't submit a PR until then |
Thank you for your reply ! I checked https://github.com/kongoncharuk/gazebo-pkgs/tree/humble, but this does not work as is. What I am a little concerned about is that I can't find the ROS2 version of the package that is listed as a dependency. Thanks. |
Which dependency do you mean? |
Dependency on the page https://github.com/JenniferBuehler/gazebo-pkgs/wiki/Installation. It did not affect me in grasping, but I have not built the rest of the system and do not yet know the effect. |
That's the install instructions, so I'm not quite sure what you mean. There are several package dependencies listed. Some are my packages, they have to be ported too. |
I have already been able to migrate the gazebo grasp plugin to Humble. I was hoping to be able to migrate other features as well. If only grasping is ok, I will create a PR. |
I will send you a PR for the grasping function only. When I do a colcon build, I get a build error due to a package that is not related to grasping. |
No worries. Don't worry about the PR for grasping only. That will be moved into its own repo some time this month anyway. Maybe you can patch things up on your side without worrying too much about things being clean, and once I've got things ported I'll let you know and you can just switch over? |
I'm not sure what you mean, and it's hard to tell without knowing which error. |
@yulat214 @JenniferBuehler |
Sorry, there are still no updates on the humble branch on this repo. It was only created so the PR could be made onto it. I think the work on the branch you linked must have been stopped. I will delete my branch because it causes confusion, understandably. Moving this to ROS2 has been on my TODO list for so long, I just don't have the time to get around to it :( It's on my radar for way too long. I think I need to take a holiday so I can finally do it 😆 😢 |
Hi,
I have checked #57, but this does not work as is.
I want to be able to use the humble branch easily.
Can I then send a pull request instead of #57?
Thanks.
The text was updated successfully, but these errors were encountered: