Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tablesnap allows a custom path separator, but tableslurp assumes ':' #69

Open
devmage opened this issue Mar 1, 2016 · 1 comment · May be fixed by #93
Open

tablesnap allows a custom path separator, but tableslurp assumes ':' #69

devmage opened this issue Mar 1, 2016 · 1 comment · May be fixed by #93

Comments

@devmage
Copy link

devmage commented Mar 1, 2016

Compare https://github.com/JeremyGrosser/tablesnap/blob/master/tableslurp#L85 and https://github.com/JeremyGrosser/tablesnap/blob/master/tablesnap#L459 .

Tablesnap's interface allows a user to configure a custom path separator, defaulting to : but configurable also with arbitrary separators or '' to achieve no separator.

Tableslurp assumes the use of specifically a : separator, and so is incompatible with any implementation of Tablesnap that uses a custom keyname separator.
@katrielt
Copy link

katrielt commented May 1, 2016

So does tablechop - https://github.com/JeremyGrosser/tablesnap/blob/master/tablechop#L45

@yawboateng yawboateng linked a pull request Jan 21, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow custom path separator on tableslurp and tablechop yawboateng/tablesnap
2 participants
@devmage @katrielt