Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineChart doesn't connect points that skip a point #468

Open
1 of 2 tasks
garrettg123 opened this issue May 1, 2020 · 3 comments · May be fixed by #475
Open
1 of 2 tasks

LineChart doesn't connect points that skip a point #468

garrettg123 opened this issue May 1, 2020 · 3 comments · May be fixed by #475
Labels

Comments

@garrettg123
Copy link

What is the problem?

The LineChart doesn't connect points when they skip 1+ point.

When does it happen?

Render a LineChart with a missing point in the middle. Eg. When your XAxis is Monday-Sunday, a point for Tuesday is missing.

What platform?

  • iOS
  • Android

react-native version: 0.61
react-native-svg-charts version: 5.3.0
react-native-svg version: 9.13.3

Code to reproduce

// put code here
@garrettg123 garrettg123 added the bug label May 1, 2020
@JesperLekland
Copy link
Owner

you control the data, just filter the empty point out. The behaviour is correct, missing point = no line

@garrettg123
Copy link
Author

@JesperLekland the point doesn't exist already, but I need the X Axis to still show up linearly otherwise it looks weird. In my case, it's the days of the week. In this sample image below, the points for Friday and Saturday are missing, but I'd still like a line to connect Thursday to Sunday:
IMG_C9D291B6539C-1

@JesperLekland
Copy link
Owner

Thank you for supplying the screenshot. From a personal perspective I find it a bit weird to have a continuous line for data that doesn't exist but of course we'd like to support all use cases.

I don't actively maintain this library anymore but would love it if you could create a PR with a nice solution for this case. I'd start with having a look this line and work my way from there

@JesperLekland JesperLekland reopened this May 5, 2020
@rferdosi rferdosi linked a pull request May 18, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants