(iOS RetroArch) hard crash when exiting pictochat on DS

[duckfromdiscord]

the RetroArch app immediately crashes after following these steps:

• open RetroArch
• select core menu
• pick melonDS DS
• load core directly
• open pictochat
• pick a room
• hit B to exit and A to confirm

retroarch2.log

[MrRedstone54]

Following up on this issue:
The same crash occurs when closing the core via the quickmenu option: Close Content
retroarch__2023_07_11__14_56_41.log

[JesseTG]

Pretty sure I fixed this, but I'd like to be certain. Could you try out the latest build and report back?

[duckfromdiscord]

Still getting this crash with https://github.com/JesseTG/melonds-ds/suites/15056859797/artifacts/859801007

[JesseTG]

This may actually be two separate bugs, neither of which is actually in melonDS DS.

The first was fixed by this PR yesterday.

The second relates to the "Load Dummy on Core Shutdown" setting, which by default is ON for most platforms but OFF for iOS and consoles. Calling RETRO_ENVIRONMENT_SHUTDOWN while this option is disabled will cause RetroArch itself to quit.

I can't detect this config setting at runtime, so this is what I'll do; I'll make the shutdown behavior configurable with one of two options:

• Exit the core with RETRO_ENVIRONMENT_SHUTDOWN as happens now. Will be default on most platforms.
• Show a shutdown screen with something like "it is now safe to exit the core", which will be the default on iOS and consoles.

[MrRedstone54]

To possibly follow up on you "second" bug:

It appears the same person who fixed the first bug also fixed the second one here

Something to look into?

[JesseTG]

Yes, it turns out that no one there was sure of why iOS devices were treated specially with that config option anyway. So the default is being reset (but existing config values will stay in place).

[JesseTG]

This is now fixed!