Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de.slisson.mps.conditionalEditor: "nextEditor" duplicates next available conditionalEditors with lower priority #855

Open
arimer opened this issue Jun 10, 2024 · 2 comments
Labels

Comments

@arimer
Copy link
Collaborator

arimer commented Jun 10, 2024

In case a custom conditional editor is "overriding" an existing one, the next-editor cell seems to duplicate already available conditional editors with lower priorities.

In this example someone created a conditional editor to "override" an already existing one and the result looks like this:

grafik

The Inner "border" is the one from the original editor and the outer one is the one from the overriding one.

@arimer arimer changed the title de.slisson.mps.conditionalEditor: "nextEditor" duplicates next availavle conditionalEditors with lower priority de.slisson.mps.conditionalEditor: "nextEditor" duplicates next available conditionalEditors with lower priority Jun 10, 2024
@arimer
Copy link
Collaborator Author

arimer commented Jun 18, 2024

Idea: Add "overrides" support for conditional editors:

Adding a "overrides" functionality can't be directly implemented on the conditional editor at the moment, because internally conditional editors are just transformed into regular concept editors. Those do not hayve any default "overrides" functionality and therefor it is not supported by the editor framework at all.

@alexanderpann
Copy link
Collaborator

alexanderpann commented Jun 18, 2024

We could improve the [next-editor] cell though. It generates to next applicable editor which then calls getCellFactory().createEditorCell(node, excludedEditors). You could call this code directly and add new excluded editors. The only excluded editor at the moment is the current editor but you could reference some more editors in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants