Is there a way to get the last executed command?

[joshestein]

I am trying to find a way to see whatever the last executed command was. For example, if I do ciw I am trying to search backwards for the c command. Or if I do fJ;;; I am trying to get the f command.

I see there is VimPlugin.HistoryGroup but I'm not sure how to use this.

[citizenmatt]

I don't think these commands are stored as part of history. The last command is remembered internally so it can be repeated with ., but there isn't a history of these commands. The history group is used to handle search and Ex command history, so you can press up and down in the / and : text fields to see history.

[joshestein]

I see, thank you for the info! I'm trying to fix this incompatibility between Quickscope and Sneak plugins: Mishkun/ideavim-sneak#27

The problem is that Sneak over-writes f/F/t/T mappings to reset an internal flag, Util.lastSDirection (setting it to null). When Quickscope is loaded after Sneak it again over-writes f/F/t/T mappings and so the flag will never be reset. This means whenever ; or , is pressed the SneakRepeatHandler sees lastSDirection as not null (

ideavim/src/main/java/com/maddyhome/idea/vim/extension/sneak/IdeaVimSneakExtension.kt

Line 106 in 1616aff

if (lastSDirection != null) {

) and Sneak moves the cursor to the last s/S match.

I had two thoughts about how to fix this:

1. Somehow reset the flag from inside Quickscope. I'm not sure this is possible.
2. Within Sneak, rather than checking lastSDirection inspect the history and see if the last command was f/F/t/T or s/S. This would allow compatibility between the two plugins.

I'm not sure if you have any other ideas or solutions? I'd appreciate any help in getting these two working together 😄

[citizenmatt]

I haven't looked at this in any detail, but do you know if the original Vim plugins have the same problem? If not, might be helpful to see how they avoid or handle the scenario - maybe that would also work in IdeaVim.

[joshestein]

That is good thinking!

I realised the same problem already exists within Vim. So I think the solution would be creating a reset function within Sneak, which could then be called by Quickscope on f/F/t/T. Is there an API to call another extension's command within IdeaVim?

[citizenmatt]

Calling another command isn't exactly straight forward, but essentially, you need to call injector.commandGroup.getAliasCommand(name, 1) to get a command (with count of 1), which will either be an Ex command alias entered by the user, which needs to be parsed and executed as Vimscript, or a Call command alias, which are implemented by extensions and are simple calls to JVM code. I can't promise this API won't get refactored, as it's not very friendly.

See here:

ideavim/vim-engine/src/main/kotlin/com/maddyhome/idea/vim/vimscript/model/commands/UnknownCommand.kt

Lines 41 to 61 in 71bcee2

	val commandAlias = injector.commandGroup.getAliasCommand(name, 1)
	when (commandAlias) {
	is GoalCommand.Ex -> {
	if (commandAlias.command.isEmpty()) {
	val message = injector.messages.message(Msg.NOT_EX_CMD, name)
	throw InvalidCommandException(message, null)
	}
	val parsedCommand = injector.vimscriptParser.parseCommand(commandAlias.command) ?: throw ExException("E492: Not an editor command: ${commandAlias.command}")
	return if (parsedCommand is UnknownCommand) {
	processPossiblyAliasCommand(commandAlias.command, editor, context, aliasCountdown - 1)
	} else {
	parsedCommand.vimContext = this.vimContext
	parsedCommand.execute(editor, context)
	ExecutionResult.Success
	}
	}
	is GoalCommand.Call -> {
	commandAlias.handler.execute(name, ranges, editor, context)
	return ExecutionResult.Success
	}
	}

There is an API to export a JVM function as a Vimscript function, so it would be possible to then write a mapping that would call a named function in your ~/.ideavimrc. I don't know if this would be more useful for this scenario.

ideavim/src/main/java/com/maddyhome/idea/vim/extension/VimExtensionFacade.kt

Lines 219 to 254 in a81d54e

	@JvmStatic
	public fun exportScriptFunction(
	scope: Scope?,
	name: String,
	args: List<String>,
	defaultArgs: List<Pair<String, Expression>>,
	hasOptionalArguments: Boolean,
	flags: EnumSet<FunctionFlag>,
	function: ScriptFunction
	) {
	var functionDeclaration: FunctionDeclaration? = null
	val body = listOf(object : Executable {
	// This context is set to the function declaration during initialisation and then set to the function execution
	// context during execution
	override lateinit var vimContext: VimLContext
	override var rangeInScript: TextRange = TextRange(0, 0)
	override fun execute(editor: VimEditor, context: ExecutionContext): ExecutionResult {
	return function.execute(editor, context, functionDeclaration!!.functionVariables)
	}
	})
	functionDeclaration = FunctionDeclaration(
	scope,
	name,
	args,
	defaultArgs,
	body,
	replaceExisting = true,
	flags,
	hasOptionalArguments
	)
	functionDeclaration.rangeInScript = TextRange(0, 0)
	body.forEach { it.vimContext = functionDeclaration }
	injector.functionService.storeFunction(functionDeclaration)
	}
	}

[citizenmatt]

Interestingly, I had a wander through some of the linked issues about this problem in the Vim plugins, and one of the comments mentions a patch to Vim that would allow scripts to know what character was last used by f/F/t/T and direction, etc. which would be pretty helpful here. Unfortunately, the link is broken, but with a bit of luck, I found the thread on Google Groups. It suggests using the getcharsearch and setcharsearch functions, which allow a script to get the last used character, direction, etc. of a character search, and to set it too. This seems like a nice solution, if both plugins used it. I.e. sneak would read from this value to get the last char/direction, and quick scope could write to it to reset it. Ironically, neither of the Vim plugins use it.

Also, IdeaVim doesn't implement these functions 😁. But they could be added...