Add support for escape() vim function

[jphalip]

No description provided.

[citizenmatt]

It would be good to extract this to a separate test class, perhaps under a builtin folder, so we can have separate files for each function, and allow splitting the test into more logical tests/asserts.

[citizenmatt]

Probably worth adding a couple of tests for invalid method calls - too many parameters, not enough parameters, what happens with invalid data types, etc.

[jphalip]

@citizenmatt I've added a couple of tests with errors.

I also agree that it'd be nice to separate these buitlin functions out to separate class, but maybe this should be done in bulk in a separate PR?

[AlexPl292]

Thank you for your PR! Can you please take a look and write a test on how this would work with multicharacter symbols like 😀?

[AlexPl292]

Please check the comments

[jphalip]

I've improved the implementation to support unicodes, emojis, etc. and added multiple other tests.

However, maybe this is overachieving? For example, standard vim appears to ignore escaping of emojis:

Standard vim:

:echo escape("😀🎉✨", "😀✨")
😀🎉✨

This implementation:

typeText(commandToKeys("""echo escape("😀🎉✨", "😀✨")"""))
assertExOutput("\\😀🎉\\✨")

Let me know if you're ok with this or if you'd like to scale back to the standard behavior.

[AlexPl292]

Oh, sorry, I didn't mean THAT accurate :D
I mentioned 😀 because I thought that iterating over code points (via String.codePoints()) would generally solve the issue. Will working just with codepoints make the escaping more accurate? If not, let's use the original behavior because it looks much simpler and more stable :)

[AlexPl292]

Note: I closed & reopened the PR by accident

[jphalip]

@AlexPl292 I've reverted to my original, simpler implementation. I also added some tests for unicode, and verified that the results are the same in standard Vim.

[AlexPl292]

Great, thank you!