From a574ef70b33dbfbc54978110fa781b7f9e20db1f Mon Sep 17 00:00:00 2001 From: David Chen Date: Fri, 17 Feb 2017 21:46:33 +0800 Subject: [PATCH] Fix a bug in updater causing update zip file to fail to extract because the target directory contains file with the same name. --- src/QSP/Updates/Updater.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/QSP/Updates/Updater.cs b/src/QSP/Updates/Updater.cs index e48f3a89..66dd879c 100644 --- a/src/QSP/Updates/Updater.cs +++ b/src/QSP/Updates/Updater.cs @@ -5,6 +5,7 @@ using System.Linq; using System.Net; using System.Xml.Linq; +using QSP.LibraryExtension; using QSP.LibraryExtension.XmlSerialization; using static QSP.Utilities.LoggerInstance; using static QSP.Utilities.ExceptionHelpers; @@ -141,7 +142,11 @@ public static void Install(UpdateInfo info) client.DownloadFile(info.Uri, zipFilePath); } + IOMethods.ClearDirectory(extractDir); + + // This creates extractDir if necessary. ZipFile.ExtractToDirectory(zipFilePath, extractDir); + IgnoreException(() => File.Delete(zipFilePath)); }