Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlarge dG limits #361

Open
Shakrim opened this issue Nov 13, 2024 · 3 comments
Open

Enlarge dG limits #361

Shakrim opened this issue Nov 13, 2024 · 3 comments

Comments

@Shakrim
Copy link

Shakrim commented Nov 13, 2024

Hi Jochem,

would be possible to enlarge dG_limits in make_dict function form {"start": 10, "end": 50} to {"start": -10, "end": 50}. I wanted to simulate the calculation of the D-uptake of a peptide, given the parameters of the Linderstrøm-lang model in peptide app. But hard limit is 10-50 KJ/mol. We have initial dGs calculated from previous experiment having negative values. Shall I create pull request? I push the branch for review? Thank you for considering.

@Jhsmit
Copy link
Owner

Jhsmit commented Nov 13, 2024

Hi, yes if you have code for PR that would be very welcome

@Shakrim
Copy link
Author

Shakrim commented Nov 15, 2024

Could you grant me access to be able push my branch for PR?

@Jhsmit
Copy link
Owner

Jhsmit commented Nov 15, 2024

If you have a fork of PyHDX then you should be able to make a PR from there
In short the procedure is 1) make a fork 2) clone the fork, make a branch and commit your changes to the branch 3) push your changes to your fork and then make a pull request upstream (on this repo)

There is more information here:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants