Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo error as_two_stage in return of PstrTransformer.forward method #14

Open
AwePhD opened this issue Sep 26, 2023 · 0 comments
Open

typo error as_two_stage in return of PstrTransformer.forward method #14

AwePhD opened this issue Sep 26, 2023 · 0 comments

Comments

@AwePhD
Copy link

AwePhD commented Sep 26, 2023

I ran the inference code with as_two_stage=True in the config file. And there is an error

I see in you code, notably in PSTRHead and PstrTransfomer you provide if else in case we use a as_two_stage Deformable DETR. Although, when I try to run your code with this parameter, it does not run. The PSTRHead.forward method issues an error, "too much values to unpack". Because in the return of self.transfomer you there are two cases and the self.as_two_stage branch misses to return the inter_reid_states variable. With adding the missing variable, the inference is done correctly.

Firstly I create this issue just to notify the small omission.

Secondly, I ask a confirmation that you did not use this Deformable DETR extension - the two stage detector extension - for your paper's result, please? There is an ablation study about one stage versus two stages but, from my understand, it is not about the two stages of the detector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant