From 851a01a4d78e65a453d461b7b8d7d250ca0bb18b Mon Sep 17 00:00:00 2001 From: Vinicius Fortuna Date: Thu, 7 Nov 2024 17:26:20 -0500 Subject: [PATCH] fix: disable revocation test --- transport/tls/stream_dialer_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/transport/tls/stream_dialer_test.go b/transport/tls/stream_dialer_test.go index 42781439..3f6980f9 100644 --- a/transport/tls/stream_dialer_test.go +++ b/transport/tls/stream_dialer_test.go @@ -17,7 +17,6 @@ package tls import ( "context" "crypto/x509" - "runtime" "testing" "github.com/Jigsaw-Code/outline-sdk/transport" @@ -55,9 +54,10 @@ func TestExpired(t *testing.T) { } func TestRevoked(t *testing.T) { - if runtime.GOOS == "linux" || runtime.GOOS == "windows" { - t.Skip("Certificate revocation list is not up-to-date in Linux and Windows") - } + t.Skip("Certificate revocation list is not working") + + // TODO(fortuna): implement proper revocation test. + // See https://www.cossacklabs.com/blog/tls-validation-implementing-ocsp-and-crl-in-go/ sd, err := NewStreamDialer(&transport.TCPDialer{}) require.NoError(t, err)