Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host() and port() to mobileproxy #96

Closed
fortuna opened this issue Oct 12, 2023 · 1 comment
Closed

Add host() and port() to mobileproxy #96

fortuna opened this issue Oct 12, 2023 · 1 comment
Labels
feature request New feature or request

Comments

@fortuna
Copy link
Contributor

fortuna commented Oct 12, 2023

Currently mobileproxy.RunProxy returns a mobileproxy.Proxy with a address getter, which returns a host:port string.
However, most code to configure the network stack needs separate host string and port number. This means the client has to split the string, and convert the port to number.

To make it easier on the client, we should provide Proxy.host() and Proxy.port() instead.
Or perhaps return an Address type with those methods.

@fortuna
Copy link
Contributor Author

fortuna commented Oct 17, 2023

Implemented in #107

@fortuna fortuna closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant