You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also, as a separate note, I had to deploy on Windows and to make it work I had to send an additional 0 to the devices. Then everything was working; without it the lights were ignoring any commands. I have no idea why it works with the 0.
And I had 2 different devices, a Luxafor ORB and a Kuando, and both behaved the same.
@aponoran I created a new issue to track the Windows extra byte problem.
As I mentioned in #416, we need to preserve the write_strategy property which encodes which write method a device needs: write or send_feature_report. I mentioned making the windows check in the __bytes__ magic method but I think it makes more sense to check for windows in the method: busylight.lights.light.Light.update. I'm going to commit an update in a second with a terrible first pass check for Windows.
I added a check to the method `busylight.lights.light.Light.update`
that prepends a zero byte to the bytes object that will be sent to
a device if the current platform is Windows. This is necessary because
the Windows HID API requires a report ID to be sent with the data and
the underlying hidapi library doesn't seem to handle this for us on Windows
but does handle it on Linux and macOS.
Also, as a separate note, I had to deploy on Windows and to make it work I had to send an additional 0 to the devices. Then everything was working; without it the lights were ignoring any commands. I have no idea why it works with the 0.
And I had 2 different devices, a Luxafor ORB and a Kuando, and both behaved the same.
Originally posted by @aponoran in #416 (comment)
The text was updated successfully, but these errors were encountered: