From 78d761b8d1876494412ed944840a29bd758744a1 Mon Sep 17 00:00:00 2001
From: Jimmy Lu <jimmylu@meta.com>
Date: Sat, 23 Nov 2024 17:51:38 -0800
Subject: [PATCH] fix: Delta update reader lifecycle issue (#11639)

Summary:
Pull Request resolved: https://github.com/facebookincubator/velox/pull/11639

In ScanSpec we only clear the column updater for root but not the
actual columns, this results in lifecycle issue when a non-Metalake split is
following a Makelake split.

bypass-github-export-checks

Reviewed By: amitkdutta

Differential Revision: D66402400

fbshipit-source-id: 88c8280252aa563ce058729b8caf0c38b660edd1
---
 velox/dwio/common/ScanSpec.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/velox/dwio/common/ScanSpec.h b/velox/dwio/common/ScanSpec.h
index 794b335e988b..06072885b195 100644
--- a/velox/dwio/common/ScanSpec.h
+++ b/velox/dwio/common/ScanSpec.h
@@ -346,7 +346,7 @@ class ScanSpec {
     for (auto& child : children_) {
       // Only top level columns can have delta updates.
       if (child->deltaUpdate_) {
-        setDeltaUpdate(nullptr);
+        child->setDeltaUpdate(nullptr);
       }
     }
   }