Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react & react-dom should be declared in peerDependencies section #10

Open
chenxinyanc opened this issue Nov 23, 2022 · 0 comments
Open

react & react-dom should be declared in peerDependencies section #10

chenxinyanc opened this issue Nov 23, 2022 · 0 comments

Comments

@chenxinyanc
Copy link

We are currently using this package on react 18 / react-dom 18, but our package manager decides to install a duplicate react 17 / react-dom 17 because the version spec in the package.json has restricted the react major version to be 17

https://github.com/Joeyonng/react-jupyter-notebook/blob/deddebcce78180818ba0d8479edf09f86f42f9ed/package.json#L34-35

Could you please

  1. Loosen the react version spec from ^17.0.1 to >=17.0.1
  2. Declare dependency to react / react-dom in peerDependencies section?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chenxinyanc