Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FiveM Lua syntax #855

Open
Gellipapa opened this issue Jan 27, 2024 · 13 comments
Open

Support FiveM Lua syntax #855

Gellipapa opened this issue Jan 27, 2024 · 13 comments
Labels
enhancement New feature or request

Comments

@Gellipapa
Copy link

I've recreated the issue because now the full-moon has been rewritten.

@JohnnyMorganz Hi!
I recently asked the creator of full-moon about when the parse rewrite will be done and he said that it will be done before the end of the day. I checked the next day and it was already merged.

I would like some help on how I can ?. and ` manage it using stylua and full-moon.

Thank you very much for your reply in advance.

@JohnnyMorganz
Copy link
Owner

Hey, sure. I will look into adding fivem Lua support in full-moon soon

@Gellipapa
Copy link
Author

Gellipapa commented Jan 27, 2024

Hey, sure. I will look into adding fivem Lua support in full-moon soon

Hi! Thanks for the quick reply.

If you could send me some description how to include such a charachter treatment I would be glad to have a look.

I would also be interested in implementation but thanks a lot if you do it.

@Gellipapa
Copy link
Author

@JohnnyMorganz Hi! Can you give me some status? Have you managed to implement the logic in full-moon? Thanks for the answer in advance.

@JohnnyMorganz
Copy link
Owner

Hey, no progress unfortunately. I haven't had the chance to work on full-moon yet. We still need to also update full-moon in stylua too, but it currently has some stack overflow issues that require fixing.

Do you have a list of all the Lua differences introduced in FiveM lua?

@Gellipapa
Copy link
Author

Hey, no progress unfortunately. I haven't had the chance to work on full-moon yet. We still need to also update full-moon in stylua too, but it currently has some stack overflow issues that require fixing.

Do you have a list of all the Lua differences introduced in FiveM lua?

It's okey. I don't have a list, unfortunately, but I know about the ones that work in the FiveM lua part. ? ` += -=
Thanks.

@JohnnyMorganz
Copy link
Owner

I think most of these should work already in stylua due to overlap with the Luau syntax.

What code is currently failing to format with stylua?

@Gellipapa
Copy link
Author

Gellipapa commented May 18, 2024

I think most of these should work already in stylua due to overlap with the Luau syntax.

What code is currently failing to format with stylua?

` and ? these characters.

image

https://github.com/esx-framework/esx_core/blob/main/%5Bcore%5D/esx_multicharacter/server/main.lua#L173

This was one of the errors that caused the stylua not to run.

@Gellipapa
Copy link
Author

@JohnnyMorganz Hi! Sorry for ping. Can you give me some status on this? Thanks.

@Gellipapa
Copy link
Author

@JohnnyMorganz Hi! What's up? Is there anything we can do to manage these characters?

@JohnnyMorganz
Copy link
Owner

Very sorry, I just have not had a chance to work on this project recently. It is still on my (somewhat large) TODO list

@Gellipapa
Copy link
Author

@JohnnyMorganz Hi! I saw the 2.0 update that you see in the near future this option to ignore these character cases?

Thanks for your reply.

@JohnnyMorganz
Copy link
Owner

Hey, sorry once again for the delay. Yes I think it shouldn't be too hard to add this now that the new syntax support was added. I am going to aim to solve this for the next release

@JohnnyMorganz JohnnyMorganz changed the title Question- Support ? and ` characters? Support FiveM Lua syntax Nov 17, 2024
@JohnnyMorganz JohnnyMorganz added the enhancement New feature or request label Nov 17, 2024
@JohnnyMorganz
Copy link
Owner

For my own reference, the extended syntax is documented at https://github.com/citizenfx/lua/blob/luaglm-dev/cfx/README.md#power-patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants