Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script URLs are not resolved correctly #21

Open
warpech opened this issue Jan 5, 2017 · 1 comment
Open

Script URLs are not resolved correctly #21

warpech opened this issue Jan 5, 2017 · 1 comment

Comments

@warpech
Copy link
Contributor

warpech commented Jan 5, 2017

When used in a partial in a Starcounter app, juicy-ace-editor 1.2.0 and 1.2.1 resolves URLs for Ace scripts relative to the main document:

2017-01-05 14_02_22-content

@warpech
Copy link
Contributor Author

warpech commented Jan 9, 2017

It turns out this is an old issue.

These scripts need to be loaded outside <juicy-ace-editor>, between the import and the instance. Here is how I did that:

https://github.com/StarcounterPrefabs/Content/blob/e09818d2489857fc8023fff67ec27d399fa330c9/src/Content/wwwroot/Content/elements/content-wrapped-juicy-ace-editor/content-wrapped-juicy-ace-editor.html#L1-L6

I propose that a relevant instruction is added to README.md

@warpech warpech added this to the Juicy elements support milestone Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant