Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test cases #55

Open
alecloudenback opened this issue Oct 3, 2021 · 3 comments
Open

Add more test cases #55

alecloudenback opened this issue Oct 3, 2021 · 3 comments

Comments

@alecloudenback
Copy link
Member

such as those in this file: https://github.com/JuliaActuary/ActuaryUtilities.jl/blob/master/test/runtests.jl

@KuldeepBorkar
Copy link
Contributor

@alecloudenback can you please explain a bit more of which functions more test cases needs to be added in which file or with a particular example please?
I am trying to contribute to Julia as a complete beginner therefore confused a bit ; (
Please help!

@alecloudenback
Copy link
Member Author

Hi Kudeep, I'd be happy to work with you, but won't be able to provide much active guidance in the short term. Examples of what to add would be examples from the literature such as calculation of an IRR, calculation of bond duration, key rate duration, etc. Basically take a look at a finance/insurance textbook and see if this package provides similar functionality.

For example, if you have a textbook which has an example of calculating the duration of a series of cashflows, call ActuariesUitilites.duration(yield,cashflows) and document that it equals what the texbook says the answer should be.

Complete example:

texbook says the duration of cashflows [10,10,10,10,10] using a 5% yield should be [x], then show in a pluto notebook what the refence is that you are citing and that ActuariesUitilites.duration(0.05,[10,10,10,10,10]) equals [x]

Even if you just do that in a notebook or something, at a future point in time I could walk you through turning that into a pull request

@KuldeepBorkar
Copy link
Contributor

@alecloudenback Okay I will try to read some textbooks solve some problems and then write some more good test cases from the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Documentation and Tests
Development

No branches or pull requests

2 participants