-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging with ClimateEasy.jl #112
Comments
Hello! Interesting to see the work you've done. I think there's not a lot of overlap and some functions would be useful. I propose that you list your most robust/useful functions and we start with that? |
The most robust functions that I have are found in:
|
ok, nice! Would you like to sketch a PR and we build on that? I'd begin with regions.jl in my opinion. |
alright! I'll fork and add? |
Seems fine to me! Meanwhile, I'm gonna split ClimateTools and create ClimatePlots in the next coming days/week and then migrate over JuliaClimate. |
One thing that will need to be done for merging will be to document the functions and create tests. |
Hi Balinus! I am currently in the process of rewriting the regions.jl codes and fix some bugs, and upgrading ClimateSatellite.jl (one of my other packages, which uses ClimateEasy.jl as a dependency), so this will take longer than expected. |
No problem! ClimateSatellite.jl seems really interesting! Clearly outside my expertise domain! 😄 |
I have finished rewriting the regions.jl code and updated ClimateEasy.jl to v0.2 to reflect that. I'll be transferring that part to ClimateTools.jl as well soon, and will submit a pull request to that effect within the next few days. Just note that none of my codes use the ClimGrid structure that many of your functions are based around, so I'm not sure if that's going to be a problem? Also, should I merge this into ClimateTools or ClimateBase? |
ok, perhaps if you provide some example on how you use the functions? I'll be able to connect it to ClimGrid then. On which type do you use the functions? For the merging, I'd say that generally, if the functions are useful for both ClimateTools and ClimatePlots -> merge with ClimateBase. if it's only relevant for analysis, merge it with ClimateTools. Anyway, we can always move it later on if it seems more practical elsewhere. (It might even be a new package). |
Hey @Balinus, just wanted to let you know that I've put up one of my repositories ClimateEasy.jl into JuliaClimate. However, I think eventually to prevent confusion I should merge the repository into ClimateTools.jl, but my way of coding might be quite different from yours.
Could you let me have a look and see what you think about merging the two repositories and how we should go about doing it?
The text was updated successfully, but these errors were encountered: