Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.11 breaks precompilation of depent packages #51

Closed
marius311 opened this issue Dec 7, 2024 · 2 comments
Closed

v0.11 breaks precompilation of depent packages #51

marius311 opened this issue Dec 7, 2024 · 2 comments

Comments

@marius311
Copy link
Contributor

marius311 commented Dec 7, 2024

If your package Foo depends on PlotlyLight then because of

ed2bc3c#diff-607aa798775b3d7a27ebf3f1388885aa1700f02024b6e97bf56a157fadd08326R15-R21

you get

Failed to precompile Foo [9ce808a0-219e-4859-ab2b-09515ef07fa1] to "/Users/marius/.julia/compiled/v1.11/Foo/jl_TkvSg1".
ERROR: LoadError: InitError: Evaluation into the closed module `PlotlyLight` breaks incremental compilation because the side effects will not be permanent. This is likely due to some other module mutating `PlotlyLight` with `eval` during precompilation - don't do this.
Stacktrace:
  [1] eval
    @ ./boot.jl:430 [inlined]
  [2] __init__()
    @ PlotlyLight ~/.julia/packages/PlotlyLight/5gUUf/src/PlotlyLight.jl:19

I think used to be a warning (I'm not sure) but it certainly appears to be an error in Julia 1.11. This seems related too: JuliaLang/julia#39648

@joshday joshday closed this as completed in accb03d Dec 8, 2024
@joshday
Copy link
Member

joshday commented Dec 8, 2024

Thank for the issue! Fixed on master. Release coming in a moment.

@marius311
Copy link
Contributor Author

Thanks for the quick fix! One other small thing just gonna comment here since its so small I think there's a missing ::Plot on

Base.show(io::IO, ::MIME"juliavscode/html", o) = show(io, MIME("text/html"), o)
which leads to everything in vscode being sent to the plot pane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants