Fix tests on Julia 1.3 #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older Julia would error when approx_size called with empty columns, due to summing an empty vector. replace with a reduce() call that has an init value, like sum on newer Julia.
|
In combination with JuliaParallel/Dagger.jl#296, JuliaParallel/Dagger.jl#297, and JuliaData/IndexedTables.jl#288, the test suite now passes on Julia 1.6.3 (macOS), Julia 1.7.0-rc1 (linux via docker), and Julia 1.3.1 (linux via docker). The Windows test that was failing before in #389 is passing for me, though I'm getting unrelated Windows test failures that I think are due to incorrectly-configured permissions on the VM I'm using. |
|
Dagger 0.13.7 is available with your 2 bugfix PRs merged |
Heptazhou
pushed a commit
to Heptazhou/JLdb.jl
that referenced
this pull request
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes the tests on Julia 1.3, by replacing a sum of an empty list with a reduce that has an initial value. It also fixes one test error on Julia 1.7 (DataType.mutable has been replaced by ismutabletype()), but more remain. I likely won't have time to get to investigating them until next week. I also haven't investigated the Windows test failures yet.
Since test suite work is happening in #389, I based my branch off that one. Let me know if you'd like a different base.