Support Decimals.jl v0.5 #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2025 21:39
* Decimals.jl v0.5 drops decimal() function, replace it with parse(Decimal, "...") * workaround the difference between the printing precision of BigFloat and the storage precision of Decimal.
|
@iamed2 / @quinnj Could either of you review this PR? And, if it looks good to you, release a new patch version? A number of packages, e.g. Turing.jl or SymbolicUtils.jl indirectly depend on Decimals.jl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a version of PR #306 that, in addition to updating the Decimals.jl to 0.5, also fixes the decimals-related tests.
The details for the test fixes are in the 2nd commit message.
I think the remaining test failures (more allocs than expected and some error message inconsistencies) are not related to decimals.
Closes #306