Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CommutativeMulNumber everywhere it is needed (and no where it isn't) #504

Open
sethaxen opened this issue Aug 18, 2021 · 0 comments · May be fixed by #540
Open

Use CommutativeMulNumber everywhere it is needed (and no where it isn't) #504

sethaxen opened this issue Aug 18, 2021 · 0 comments · May be fixed by #540
Assignees
@sethaxen

Comments

@sethaxen
Copy link
Member

Currently, rules for * are constrained to CommutativeMulNumber types. This is unnecessary, because only two numbers at a time are multiplied, so commutation is never needed. These constraints should be relaxed.

Conversely, the scalar rule for ^ requires commutativity but makes no such type constraint. It should be limited to CommutativeMulNumber.

There may be other cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sethaxen sethaxen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assume commutative multiplication exactly when necessary JuliaDiff/ChainRules.jl
1 participant
@sethaxen