From a3816f626f73d67fa6843716a54cf7403d092c91 Mon Sep 17 00:00:00 2001
From: Matt Brzezinski <matt.brzezinski@invenia.ca>
Date: Tue, 6 Apr 2021 13:01:48 -0500
Subject: [PATCH] Addressed PR comments

---
 src/PkgDeps.jl                                    |  3 +--
 test/resources/registries/Foobar/Case1/Deps.toml  |  2 +-
 test/resources/registries/Foobar/Case2/Deps.toml  |  2 +-
 test/resources/registries/General/Case3/Deps.toml |  2 +-
 test/resources/registries/General/Case4/Deps.toml |  2 +-
 test/resources/registries/README.md               | 10 +++++-----
 test/runtests.jl                                  |  4 ++--
 7 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/src/PkgDeps.jl b/src/PkgDeps.jl
index 4a1b80c..81bb844 100644
--- a/src/PkgDeps.jl
+++ b/src/PkgDeps.jl
@@ -31,9 +31,8 @@ function _get_latest_version(base_path::AbstractString)
     if isfile(versions_file_path)
         versions_content = parsefile(versions_file_path)
         versions = [VersionNumber(v) for v in collect(keys(versions_content))]
-        sort!(versions, rev=true)
 
-        return first(versions)
+        return first(findmax(versions))
     end
 end
 
diff --git a/test/resources/registries/Foobar/Case1/Deps.toml b/test/resources/registries/Foobar/Case1/Deps.toml
index cef037f..4977338 100644
--- a/test/resources/registries/Foobar/Case1/Deps.toml
+++ b/test/resources/registries/Foobar/Case1/Deps.toml
@@ -1,2 +1,2 @@
 [0]
-UpDep = "000eeb74-f857-587a-a816-be5685e97e75"
+DownDep = "000eeb74-f857-587a-a816-be5685e97e75"
diff --git a/test/resources/registries/Foobar/Case2/Deps.toml b/test/resources/registries/Foobar/Case2/Deps.toml
index ba36cd3..9548894 100644
--- a/test/resources/registries/Foobar/Case2/Deps.toml
+++ b/test/resources/registries/Foobar/Case2/Deps.toml
@@ -1,2 +1,2 @@
 ["0.1-0"]
-UpDep = "000eeb74-f857-587a-a816-be5685e97e75"
+DownDep = "000eeb74-f857-587a-a816-be5685e97e75"
diff --git a/test/resources/registries/General/Case3/Deps.toml b/test/resources/registries/General/Case3/Deps.toml
index fefdbeb..f3fe1c1 100644
--- a/test/resources/registries/General/Case3/Deps.toml
+++ b/test/resources/registries/General/Case3/Deps.toml
@@ -1,2 +1,2 @@
 ["1"]
-UpDep = "000eeb74-f857-587a-a816-be5685e97e75"
+DownDep = "000eeb74-f857-587a-a816-be5685e97e75"
diff --git a/test/resources/registries/General/Case4/Deps.toml b/test/resources/registries/General/Case4/Deps.toml
index de79488..83c8b7e 100644
--- a/test/resources/registries/General/Case4/Deps.toml
+++ b/test/resources/registries/General/Case4/Deps.toml
@@ -1,2 +1,2 @@
 ["0-0.1"]
-UpDep = "000eeb74-f857-587a-a816-be5685e97e75"
+DownDep = "000eeb74-f857-587a-a816-be5685e97e75"
diff --git a/test/resources/registries/README.md b/test/resources/registries/README.md
index b65bb31..ed06824 100644
--- a/test/resources/registries/README.md
+++ b/test/resources/registries/README.md
@@ -1,19 +1,19 @@
 ## Creating test cases
 When adding test cases please create another test case in any existing registry.
-Include a `Deps.toml` and `Versions.toml` files to specify when a package has been dependent
+Include `Deps.toml` and `Versions.toml` files to specify when a package has been dependent
 on another.
 
 
 ## Overview of Cases
 
 ### Case1
-Single patch pre-1.0 release that has always been dependent on `UpDep`.
+Single patch pre-1.0 release that has always been dependent on `DownDep`.
 
 ### Case2
-Single minor pre-1.0 release that has always been dependent on `UpDep`.
+Single minor pre-1.0 release that has always been dependent on `DownDep`.
 
 ### Case3
-Single post-1.0 release that is dependent on `UpDep`.
+Single post-1.0 release that is dependent on `DownDep`.
 
 ### Case4
-Two releases where `UpDep` was previously a depdenency and no longer is.
+Two releases where `DownDep` was previously a depdenency and no longer is.
diff --git a/test/runtests.jl b/test/runtests.jl
index 790b126..0e27845 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -23,14 +23,14 @@ end
     all_registries = reachable_registries(; depots=depot)
 
     @testset "specific registry" begin
-        dependents = find_downstream_dependencies("UpDep"; registries=foobar_registry)
+        dependents = find_downstream_dependencies("DownDep"; registries=foobar_registry)
 
         @test length(dependents) == 2
         [@test case in dependents for case in ["Case1", "Case2"]]
     end
 
     @testset "all registries" begin
-        dependents = find_downstream_dependencies("UpDep"; registries=all_registries)
+        dependents = find_downstream_dependencies("DownDep"; registries=all_registries)
 
         @test length(dependents) == 3
         @test !("Case4" in dependents)