Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPSMatrix improvements #157

Merged
merged 5 commits into from
Sep 5, 2023
Merged

MPSMatrix improvements #157

merged 5 commits into from
Sep 5, 2023

Conversation

tgymnich
Copy link
Member

@tgymnich tgymnich commented Mar 31, 2023 •
edited
Loading

  • add properties
  • create batch of MPSMatrices

maleadt
maleadt reviewed Apr 14, 2023
View reviewed changes
lib/mps/matrix.jl Outdated Show resolved Hide resolved
@maleadt maleadt added enhancement libraries Things about libraries and how we use them. arrays Things about the array abstraction. labels May 22, 2023
@tgymnich tgymnich marked this pull request as ready for review September 4, 2023 15:43
maleadt
maleadt reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe add a test?

@tgymnich
Copy link
Member Author

tgymnich commented Sep 5, 2023

added a test

@maleadt maleadt merged commit 69aa51e into JuliaGPU:main Sep 5, 2023
@tgymnich tgymnich deleted the MPSMatrix-improvements branch September 5, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt left review comments

Assignees
No one assigned
Labels
arrays Things about the array abstraction. libraries Things about libraries and how we use them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgymnich @maleadt