Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Support FastDifferentiation.jl as symbolic AD backend and parametric bounds #14

Closed
wants to merge 7 commits into from

Conversation

lassepe
Copy link
Member

@lassepe lassepe commented Aug 29, 2023

Draft; do not merge.

Todos

  • rebase
  • go over in-code TODO's
  • Split out parametric bounds feature
  • improve dispatch logic
  • add tests
  • update gradient rule to account for derivative in bounds
  • tag a breaking release

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (00807b2) 91.59% compared to head (43cf3de) 72.84%.

❗ Current head 43cf3de differs from pull request most recent head 86afb7d. Consider uploading reports for the commit 86afb7d to get more accurate results

Files Patch % Lines
src/parametric_problem.jl 0.00% 32 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #14       +/-   ##
===========================================
- Coverage   91.59%   72.84%   -18.75%     
===========================================
  Files           5        5               
  Lines         119      151       +32     
===========================================
+ Hits          109      110        +1     
- Misses         10       41       +31     
Flag Coverage Δ
unittests 72.84% <0.00%> (-18.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassepe lassepe force-pushed the feature/fdjl-backend branch 2 times, most recently from a97e1ec to 4c43af5 Compare September 4, 2023 16:27
@lassepe lassepe changed the title [Draft] Support FastDifferentiation.jl as symbolic AD backend [Draft] Support FastDifferentiation.jl as symbolic AD backend and parametric bounds Sep 4, 2023
@lassepe lassepe marked this pull request as draft December 13, 2023 10:43
@lassepe lassepe force-pushed the feature/fdjl-backend branch from 4c43af5 to 86afb7d Compare December 13, 2023 11:02
@lassepe lassepe closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant