Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ADTypes.jl #33

Closed
wants to merge 2 commits into from
Closed

Use ADTypes.jl #33

wants to merge 2 commits into from

Conversation

lassepe
Copy link
Member

@lassepe lassepe commented Apr 22, 2024

ADTypes does not support Julia 1.8. Hence it would be good to wait for SciML/ADTypes.jl#47 to be resolved.

Copy link

codecov bot commented Apr 22, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@lassepe lassepe marked this pull request as draft April 22, 2024 16:42
@gdalle
Copy link

gdalle commented Apr 22, 2024

If you're tinkering with several AD packages and willing to use ADTypes, you may wanna take it one step further with DifferentiationInterface. At the moment only the version on main supports the latest ADTypes, but I'm aiming for a v0.3 release in the coming weeks

@lassepe
Copy link
Member Author

lassepe commented Apr 22, 2024

Thank you for the suggestion. In our use case, it is fairly important that the AD backend is symbolic/tracing. A typical upstream use case of this package looks like this:

https://github.com/JuliaGameTheoreticPlanning/MCPTrajectoryGameSolver.jl/blob/main/src/solver_setup.jl

In that setting, the user typically provides the symbolic description of the problem rather than in terms of a callable function.

The key advantage of a symbolic approach here is that the user doesn't have to think too much about runtime performance while describing the problem (since tracing will generate an efficient in-place function for them anyway). My understanding is that DifferentiationInterface does not support that use case very well (?).

That said, I think there is value in using DifferentiationInterface on the inplace function generated by, e.g., Symbolics.build_function to generate the Jacobians; c.f. #24

@lassepe lassepe closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants