Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert nothing and missing #181

Open
alex-s-gardner opened this issue Jan 16, 2025 · 3 comments
Open

convert nothing and missing #181

alex-s-gardner opened this issue Jan 16, 2025 · 3 comments

Comments

@alex-s-gardner
Copy link
Contributor

right now:

using GeometryBasics
import GeoInterface as GI

this errors

GI.convert(GeometryBasics, missing)

and this errors

GI.convert(GeometryBasics, nothing)

should they instead return missing and nothing respectively?

@rafaqz
Copy link
Member

rafaqz commented Jan 16, 2025

Maybe missing should as it's meant to propagate? But nothing wants handling

@asinghvi17
Copy link
Member

asinghvi17 commented Jan 16, 2025

Agreed, missing nothing should always error IMO. But we can build missing into GeoInterface (I think)?

Edited

@evetion
Copy link
Member

evetion commented Jan 18, 2025

Missing could be propagated, but doesn't really need to be imho. Convert takes something that is a geometry, if you pass in something else (say 1), you can expect a (method)error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants