Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Extents.jl predicates? #242

Open
rafaqz opened this issue Dec 13, 2024 · 4 comments
Open

Extend Extents.jl predicates? #242

rafaqz opened this issue Dec 13, 2024 · 4 comments

Comments

@rafaqz
Copy link
Member

rafaqz commented Dec 13, 2024

This could reduce ecosystem name clashes

@asinghvi17
Copy link
Member

That makes sense, let's make sure they are all the same though!

@asinghvi17
Copy link
Member

Actually nevermind...we'd have to pirate these lines

https://github.com/rafaqz/Extents.jl/blob/ced3c5fa4c1761e6138e661a74acc6c8a72c5f9f/src/Extents.jl#L142-L146

and we can't depend on GeoInterface in Extents, because it's circular...

@asinghvi17
Copy link
Member

So maybe we need a GeometricPredicateFunctionStubs.jl package that just has these function stubs, and then Extents can override them for its own use.

@rafaqz
Copy link
Member Author

rafaqz commented Jan 27, 2025

Yeah but maybe we should remove those methods anyway as only GI.extent reliably works on geometries. It all needs a rethink at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants