Restore partial support for :fast rounding mode
#666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! Are there tests for this? |
|
I don't think this closes #592 , since CRlibm is used for |
|
So CORE-MATH would be faster than CRlibm? Concerning the tests: I am not sure if there ever were any. I could add some simple ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR essentially uncomments the old code we had for
+,-,*,/,inv,sqrtwith:fastrounding.Since Julia should be compliant with the IEEE specifications, these functions can only return a result within one ulp of the correct one.
Maybe we should find a reference in the Julia repo where this is mentioned?
Closes #665
Maybe this also addresses #592.
cc-@dpsanders