-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.0.0 #310
Merged
Merged
V2.0.0 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 88.00% 89.08% +1.07%
==========================================
Files 16 16
Lines 1692 1740 +48
==========================================
+ Hits 1489 1550 +61
+ Misses 203 190 -13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to contain breaking changes, the main one is using the type system to hold the indeterminate rather than use a field to hold the indeterminate. The advantage is this plays better with Julia's promotion mechanisms so matrices of polynomials requires much less fuss. The others are cleanups. For example, iteration is modified to more closely match iteration over the underlying container. Before, iteration iterated over terms, which is still supported though now through the iterator
monomials
.Polynomial
constructor to create different types of polynomials based on how the coefficients are specified. RemoveLaurentPolynomial
deprecations.OffsetArrays
are used (ok with Laurent, ignore otherwise) instead of just ignoring offset for all. RemovedOffsetArrays
as a dependency.monomials
iterator for old behaviour.integrate
withNaN
valuesErrorException
errors more informativeNon-breaking changes
fit
. (Had planned on changing how weights are specified [issue?], but held back)integrate
have methods implementintegrate(p)
, notintegrate(p,c)
.In addition, there are a few speedups to the basic operations for the
ImmutablePolynomial
andPolynomial
types.+
and*
; refactor for possible reuse.common
(truncate!, chop!, zero, one, variable, basis)