Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalidations #412

Merged
merged 1 commit into from
May 31, 2022
Merged

fix invalidations #412

merged 1 commit into from
May 31, 2022

Conversation

jverzani
Copy link
Member

Close issue #403 by fixing invalidation for any(pred, p::AbstractPolynomial).

@jishnub
Copy link
Contributor

jishnub commented May 31, 2022

Oddly I still see the invalidation

julia> trees[end-2]
inserting any(pred::Function, p::AbstractPolynomial) in Polynomials at /home/jishnu/Dropbox/JuliaPackages/Polynomials.jl/src/common.jl:489 invalidated:
   backedges: 1: superseding any(f, itr) in Base at reduce.jl:1105 with MethodInstance for any(::typeof(ismissing), ::Any) (1 children)
              2: superseding any(f, itr) in Base at reduce.jl:1105 with MethodInstance for any(::REPL.var"#5#7", ::Any) (1 children)
              3: superseding any(f, itr) in Base at reduce.jl:1105 with MethodInstance for any(::Test.var"#41#43", ::Any) (2 children)
   6 mt_cache

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #412 (eed6a62) into master (8b1c45a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files          23       23           
  Lines        2790     2790           
=======================================
  Hits         2319     2319           
  Misses        471      471           
Impacted Files Coverage Δ
src/common.jl 89.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1c45a...eed6a62. Read the comment docs.

@jverzani
Copy link
Member Author

Thanks was just about to merge. Let me check again.

@jverzani
Copy link
Member Author

Hmm,

Do you have any other things loaded (I see a reference to REPL.var). I only see this:

   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.7.3 (2022-05-06)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> using SnoopCompileCore, SnoopCompile

julia> invalidations = @snoopr using Polynomials;trees = invalidation_trees(invalidations);length(trees)
[ Info: Precompiling Polynomials [f27b6e38-b328-58d1-80ce-0feddd5e7a45]
3

julia> [tree.method for tree ∈ trees]
[1] *(::Any, z::MutableArithmetics.Zero) in MutableArithmetics at /Users/verzani/.julia/packages/MutableArithmetics/L8iac/src/rewrite.jl:59
[2] iszerodefined(::Type{<:MutableArithmetics.AbstractMutable}) in MutableArithmetics at /Users/verzani/.julia/packages/MutableArithmetics/L8iac/src/dispatch.jl:764
[3] step(r::MutableArithmetics.MutatingStepRange) in MutableArithmetics at /Users/verzani/.julia/packages/MutableArithmetics/L8iac/src/implementations/MutatingStepRange.jl:25

@jverzani jverzani merged commit c9d344c into JuliaMath:master May 31, 2022
@jverzani jverzani deleted the issue_403a branch May 31, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants