CompatHelper: bump compat for Spglib to 0.8, (keep existing compat) #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mfherbst
force-pushed
the
compathelper/new_version/2023-08-19-00-40-24-720-03962113286
branch
from
95503ea to
511fea5
Compare
|
Hi @mfherbst, I revamped the code, including but not limited to, update spglib_jll to v2.0.2, updated unified API, some API changes, updated docs, more functions and more tests. However, I need to remind you that this is a breaking change, and some of your code may need to be updated since I align the convention with Spglib (like transposing rotation matrices, etc.). If you need any help to update your code, please contact me. I'll be happy to help! |
|
Thanks for the info @singularitti. I'll take a look when I get to it (probably on the weekend). |
mfherbst
force-pushed
the
compathelper/new_version/2023-08-19-00-40-24-720-03962113286
branch
from
511fea5 to
f98b04e
Compare
|
Waiting for thchr/Brillouin.jl#27. |
12 tasks
This was referenced Nov 7, 2023
mfherbst
deleted the
compathelper/new_version/2023-08-19-00-40-24-720-03962113286
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Spglibpackage from0.6, 0.7to0.6, 0.7, 0.8.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.