Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special case for DuckDB_jll windows build #9775

Closed
wants to merge 3 commits into from
Closed

Add special case for DuckDB_jll windows build #9775

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63e34c2
Trivial change to triger build
KronosTheLate Nov 13, 2024
8050e12
Add special case for windows
KronosTheLate Nov 13, 2024
47e8236
Update D/DuckDB/build_tarballs.jl
KronosTheLate Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions D/DuckDB/build_tarballs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,32 +10,40 @@ sources = [
GitSource("https://github.com/duckdb/duckdb.git", "f680b7d08f56183391b581077d4baf589e1cc8bd"),
]

# Bash recipe for building across all platforms
script = raw"""
cd $WORKSPACE/srcdir/duckdb/

cmake -B build \
-DCMAKE_INSTALL_PREFIX=${prefix} \
-DCMAKE_TOOLCHAIN_FILE=${CMAKE_TARGET_TOOLCHAIN} \
-DCMAKE_BUILD_TYPE=Release \
-DENABLE_SANITIZER=FALSE \
-DBUILD_EXTENSIONS='autocomplete;icu;parquet;json;fts;tpcds;tpch' \
-DENABLE_EXTENSION_AUTOLOADING=1 \
-DENABLE_EXTENSION_AUTOINSTALL=1 \
-DBUILD_UNITTESTS=FALSE \
-DBUILD_SHELL=TRUE \
-DDUCKDB_EXPLICIT_PLATFORM="${target}"
cmake --build build --parallel ${nproc}
cmake --install build

if [[ "${target}" == *-mingw32 ]]; then
install -Dvm 755 "build/src/libduckdb.${dlext}" -t "${libdir}"
if [[ "$target" == *-ming* ]]; then
build_command="cmake -B build -G \"Ninja\""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we should use different commands for different platforms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me neither. I just tried to copy the build instructions from the website. I am very much shooting in the dark here.

build_extensions="icu;parquet;json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the different extensions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because the new ones are from the build instructions on the website

else
build_command="cmake -B build"
build_extensions="autocomplete;icu;parquet;json;fts;tpcds;tpch"
fi

$build_command \
-DBUILD_EXTENSIONS="$build_extensions" \
-DBUILD_SHELL=TRUE \
-DBUILD_UNITTESTS=FALSE \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$prefix \
-DCMAKE_TOOLCHAIN_FILE=$CMAKE_TARGET_TOOLCHAIN \
-DDUCKDB_EXPLICIT_PLATFORM="$target" \
-DENABLE_EXTENSION_AUTOINSTALL=1 \
-DENABLE_EXTENSION_AUTOLOADING=1 \
-DENABLE_SANITIZER=FALSE
cmake --build build --parallel $nproc
cmake --install build

if [[ "$target" == *-w64-mingw32 ]]; then
install -Dvm 755 "build/src/libduckdb.${dlext}" -t "${libdir}"
fi
"""

# These are the platforms we will build for by default, unless further
# platforms are passed in on the command line
platforms = expand_cxxstring_abis(supported_platforms())

# Building for PowerPC results in errors inside jemalloc:
# /tmp/ccmHnfhC.s: Assembler messages:
# /tmp/ccmHnfhC.s:7829: Error: unrecognized opcode: `pause'
Expand Down